From 196ef5e03e8e969d19861233b6245461ea6a21d5 Mon Sep 17 00:00:00 2001 From: Bryce Allen Date: Sun, 16 Aug 2015 10:20:28 -0500 Subject: [PATCH] rewards: sub quests are not affected by luck skill --- mhapi/rewards.py | 10 +++++++--- mhapi/stats.py | 3 +++ 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/mhapi/rewards.py b/mhapi/rewards.py index 0f700eb..2b41f97 100644 --- a/mhapi/rewards.py +++ b/mhapi/rewards.py @@ -139,9 +139,13 @@ class QuestReward(object): self.skill_delta = 0 else: # variable reward, expected number of draws depends on luck skill - counts = [stats.quest_reward_expected_c(self.slot, skill) - for skill in xrange(LuckSkill.NONE, - LuckSkill.AMAZING+1)] + if self.slot == stats.QUEST_SUB: + # sub quest rewards aren't affected by luck skill in 4U + counts = [stats.quest_reward_expected_c(self.slot)] + else: + counts = [stats.quest_reward_expected_c(self.slot, skill) + for skill in xrange(LuckSkill.NONE, + LuckSkill.AMAZING+1)] evs = [((count - self.fixed_rewards) diff --git a/mhapi/stats.py b/mhapi/stats.py index 7312ca7..66e6054 100644 --- a/mhapi/stats.py +++ b/mhapi/stats.py @@ -111,6 +111,9 @@ def quest_reward_expected_c(line=QUEST_A, luck_skill=LUCK_SKILL_NONE): elif line == QUEST_SUB: min_c = 1 max_c = 4 + # luck skill does not work on sub quests, see + # https://www.reddit.com/r/MonsterHunter/comments/307sda/fate_doesnt_appear_to_do_anything_to_subquest/ + extend_p = 22 * 100.0 / 32 else: raise ValueError()